[
https://issues.apache.org/jira/browse/SPARK-26905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129729#comment-17129729
]
Maxim Gekk commented on SPARK-26905:
------------------------------------
I downloaded SQL2016 reserved and non-reserved keywords from
https://github.com/postgres/postgres/tree/master/doc/src/sgml/keywords as
[~cloud_fan] suggested to me, and dumped Spark's keywords from the current
master SqlBase.g4:
{code:scala}
scala> val sql2016Reserved = spark.read.text("sql2016-02-reserved.txt",
"sql2016-09-reserved.txt", "sql2016-14-reserved.txt")
sql2016Reserved: org.apache.spark.sql.DataFrame = [value: string]
scala> val sql2016NonReserved = spark.read.text("sql2016-02-nonreserved.txt",
"sql2016-09-nonreserved.txt", "sql2016-14-nonreserved.txt")
sql2016NonReserved: org.apache.spark.sql.DataFrame = [value: string]
scala> val sparkKeywords = spark.read.option("sep",
":").csv("spark-keywords-list.txt").select($"_c0".as("value"))
sparkKeywords: org.apache.spark.sql.DataFrame = [value: string]
scala> val sparkNonReserved = spark.read.text("spark-nonReserved.txt")
sparkNonReserved: org.apache.spark.sql.DataFrame = [value: string]
scala> val sparkStrictNonReserved =
spark.read.text("spark-strictNonReserved.txt")
sparkStrictNonReserved: org.apache.spark.sql.DataFrame = [value: string]
scala> val sparkAnsiNonReserved = spark.read.text("spark-ansiNonReserved.txt")
sparkAnsiNonReserved: org.apache.spark.sql.DataFrame = [value: string]
scala> val sparkAnsiReserved = sparkKeywords.except(sparkAnsiNonReserved)
sparkAnsiReserved: org.apache.spark.sql.Dataset[org.apache.spark.sql.Row] =
[value: string]
{code}
There are some differences:
Spark's ANSI Reserved keywords are not reserved keywords in SQL2016:
{code:scala}
scala> sparkAnsiReserved.except(sql2016Reserved).show
+--------+
| value|
+--------+
| SEMI|
|SETMINUS|
| TYPE|
| ANTI|
+--------+
{code}
> Revisit reserved/non-reserved keywords based on the ANSI SQL standard
> ---------------------------------------------------------------------
>
> Key: SPARK-26905
> URL: https://issues.apache.org/jira/browse/SPARK-26905
> Project: Spark
> Issue Type: Sub-task
> Components: SQL
> Affects Versions: 3.0.0
> Reporter: Xiao Li
> Priority: Major
> Attachments: spark-ansiNonReserved.txt, spark-keywords-list.txt,
> spark-nonReserved.txt, spark-strictNonReserved.txt,
> sql2016-02-nonreserved.txt, sql2016-02-reserved.txt,
> sql2016-09-nonreserved.txt, sql2016-09-reserved.txt,
> sql2016-14-nonreserved.txt, sql2016-14-reserved.txt
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
