[ https://issues.apache.org/jira/browse/SPARK-31843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143597#comment-17143597 ]
Apache Spark commented on SPARK-31843: -------------------------------------- User 'beliefer' has created a pull request for this issue: https://github.com/apache/spark/pull/28866 > DAGSchedulerSuite: For the pattern of complete + assert, extract the general > method > ----------------------------------------------------------------------------------- > > Key: SPARK-31843 > URL: https://issues.apache.org/jira/browse/SPARK-31843 > Project: Spark > Issue Type: Sub-task > Components: Spark Core > Affects Versions: 3.1.0 > Reporter: jiaan.geng > Priority: Major > > DAGSchedulerSuite exists many test case(e.g. run trivial job/run trivial job > w/ dependency/cache location preferences w/ dependency) contains the pattern > of complete + assert, such as: > {code:java} > test("run trivial job") { > submit(new MyRDD(sc, 1, Nil), Array(0)) > complete(taskSets(0), List((Success, 42))) > assert(results === Map(0 -> 42)) > assertDataStructuresEmpty() > } > {code} > We should extract the general method like checkAnswer(job, expected) -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org