[
https://issues.apache.org/jira/browse/SPARK-31842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149265#comment-17149265
]
jiaan.geng commented on SPARK-31842:
------------------------------------
According discussion between [~Ngone51] and me. It's not worth to do this.
Please references my fork branch
https://github.com/beliefer/spark/commit/09ed72589a2bbd201f9c6bb61999b8b066026090
> DAGSchedulerSuite: For the pattern of runevent + assert, extract the general
> method
> -----------------------------------------------------------------------------------
>
> Key: SPARK-31842
> URL: https://issues.apache.org/jira/browse/SPARK-31842
> Project: Spark
> Issue Type: Sub-task
> Components: Spark Core
> Affects Versions: 3.1.0
> Reporter: jiaan.geng
> Priority: Major
>
> DAGSchedulerSuite exists many test case(e.g. late fetch failures / task
> events always posted / ignore late map task completions) contains the pattern
> of runevent + assert, such as:
> {code:java}
> runEvent(makeCompletionEvent(
> taskSets(1).tasks(0),
> FetchFailed(makeBlockManagerId("hostA"), shuffleId, 0L, 0, 0,
> "ignored"),
> null))
> assert(sparkListener.failedStages.contains(1))
> {code}
> We should extract the general method like runEventAndCheck(events*, predicate)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
