[ 
https://issues.apache.org/jira/browse/SPARK-32485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167881#comment-17167881
 ] 

Michael Munday commented on SPARK-32485:
----------------------------------------

This is for Linux running on the IBM Z platform (s390x) which is a big endian 
platform. I have a PR open to fix this, I will update it with this issue number 
shortly. Thanks.

> RecordBinaryComparatorSuite test failures on big-endian systems
> ---------------------------------------------------------------
>
>                 Key: SPARK-32485
>                 URL: https://issues.apache.org/jira/browse/SPARK-32485
>             Project: Spark
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 3.0.0
>            Reporter: Michael Munday
>            Priority: Minor
>              Labels: endianness
>
> The fix for SPARK-29918 broke two tests on big-endian systems:
>  * testBinaryComparatorWhenSubtractionIsDivisibleByMaxIntValue
>  * testBinaryComparatorWhenSubtractionCanOverflowLongValue
> These tests date from a time where subtraction was being used to do 
> multi-byte comparisons. They try to trigger old bugs by feeding specific 
> values into the comparison. However the fix for SPARK-29918 modified the 
> order in which bytes are compared when comparing 8 bytes at a time on 
> little-endian systems (to match the normal byte-by-byte comparison). This fix 
> did not affect big-endian systems. However the expected output of the tests 
> was modified for all systems regardless of endianness. So the tests broke on 
> big-endian systems.
> It is also not clear that the values compared in the tests match the original 
> intent of the tests now that the bytes in those values are compared in order 
> (equivalent to the bytes in the values being reversed).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to