[
https://issues.apache.org/jira/browse/SPARK-33146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217064#comment-17217064
]
Dongjoon Hyun commented on SPARK-33146:
---------------------------------------
Hi, [~kabhwan]
I don't think the revert of revert is a correct way in this JIRA. At least, if
you really want to `revert of revert`, you should make a PR and pass the UT in
the community instead of silent reverting of reverting.
-
https://github.com/apache/spark/commit/02f80cf293739f4d2881316897dbdcea74daa0bc
- Revert "Revert "[SPARK-33146][CORE] Check for non-fatal errors when loading
new applications in SHS""
In general, `Revert of revert` is used when the first revert decision was
wrong. Here, although you didn't intend it, it looks like you use it as a claim
that your first commit decision was right.
The following is the way I see this:
1. The original commit was wrong because it's committed without testing.
2. Hence, the first revert is legitimate to recover `branch-3.0`.
3. After you tweaked `branch-3.0` yesterday, you had better land SPARK-33146 as
a normal backporting PR with `[3.0]` tag instead of depending your test results
under `WIP` PR.
> Encountering an invalid rolling event log folder prevents loading other
> applications in SHS
> -------------------------------------------------------------------------------------------
>
> Key: SPARK-33146
> URL: https://issues.apache.org/jira/browse/SPARK-33146
> Project: Spark
> Issue Type: Bug
> Components: Spark Core
> Affects Versions: 3.0.1
> Reporter: Adam Binford
> Assignee: Adam Binford
> Priority: Major
> Fix For: 3.0.2, 3.1.0
>
>
> A follow-on issue from https://issues.apache.org/jira/browse/SPARK-33133
> If an invalid rolling event log folder is encountered by the Spark History
> Server upon startup, it crashes the whole loading process and prevents any
> valid applications from loading. We should simply catch the error, log it,
> and continue loading other applications.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
