[
https://issues.apache.org/jira/browse/SPARK-32084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217412#comment-17217412
]
Hyukjin Kwon commented on SPARK-32084:
--------------------------------------
Just for a bit of more context, I think we should have a better docstring wth
many examples. Also I am thinking about switching to numpydoc style
(SPARK-32085).
I can't think of a good benefit of keeping the functions as dynamically defined
.. it makes hard to write docstrings and the code deduplication is very small.
> Replace dictionary-based function definitions to proper functions in
> functions.py
> ---------------------------------------------------------------------------------
>
> Key: SPARK-32084
> URL: https://issues.apache.org/jira/browse/SPARK-32084
> Project: Spark
> Issue Type: Improvement
> Components: PySpark
> Affects Versions: 3.1.0
> Reporter: Hyukjin Kwon
> Priority: Major
>
> Currently some functions in {{functions.py}} are defined by a dictionary. It
> programmatically defines the functions to the module; however, it makes some
> IDEs such as PyCharm don't detect.
> Also, it makes hard to add proper examples into the docstrings.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
