[
https://issues.apache.org/jira/browse/SPARK-34789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Zsolt Piros updated SPARK-34789:
---------------------------------------
Description:
This came up during
https://github.com/apache/spark/pull/31877#discussion_r596831803.
Short summary: we have some tests where HTTP(S) is used to access files. The
current solution uses github urls like
"https://raw.githubusercontent.com/apache/spark/master/data/mllib/pagerank_data.txt";.
This connects two Spark version in an unhealthy way like connecting the
"master" branch which is moving part with the committed test code which is a
non-moving (as it might be even released).
So this way a test running for an earlier version of Spark expects something
(filename, content, path) from a the latter release and what is worse when the
moving version is changed the earlier test will break.
The idea is to introduce a method like:
{noformat}
withHttpServer(files) {
}
{noformat}
Which uses a Jetty ResourceHandler to serve the listed files (or directories /
or just the root where it is started from) and stops the server in the finally.
was:
This came up during
https://github.com/apache/spark/pull/31877#discussion_r596831803.
Short summary: we have some tests where HTTP(S) is used to access files. The
current solution uses github urls like
"https://raw.githubusercontent.com/apache/spark/master/data/mllib/pagerank_data.txt";.
This connects two Spark version in an unhealthy way like connecting the
"master" branch which is moving part with the committed test code which is a
non-moving (as it might be even released).
So this way a test running for an earlier version of Spark expects something
(filename, content, path) from a the latter release and what is worse when the
moving version is changed the earlier test will break.
> Introduce Jetty based construct for integration tests where HTTP(S) is used
> ---------------------------------------------------------------------------
>
> Key: SPARK-34789
> URL: https://issues.apache.org/jira/browse/SPARK-34789
> Project: Spark
> Issue Type: Task
> Components: Tests
> Affects Versions: 3.2.0
> Reporter: Attila Zsolt Piros
> Priority: Major
>
> This came up during
> https://github.com/apache/spark/pull/31877#discussion_r596831803.
> Short summary: we have some tests where HTTP(S) is used to access files. The
> current solution uses github urls like
> "https://raw.githubusercontent.com/apache/spark/master/data/mllib/pagerank_data.txt";.
> This connects two Spark version in an unhealthy way like connecting the
> "master" branch which is moving part with the committed test code which is a
> non-moving (as it might be even released).
> So this way a test running for an earlier version of Spark expects something
> (filename, content, path) from a the latter release and what is worse when
> the moving version is changed the earlier test will break.
> The idea is to introduce a method like:
> {noformat}
> withHttpServer(files) {
> }
> {noformat}
> Which uses a Jetty ResourceHandler to serve the listed files (or directories
> / or just the root where it is started from) and stops the server in the
> finally.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
