[
https://issues.apache.org/jira/browse/SPARK-35763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jungtaek Lim resolved SPARK-35763.
----------------------------------
Fix Version/s: 3.2.0
Resolution: Fixed
Issue resolved by pull request 32914
[https://github.com/apache/spark/pull/32914]
> Minor refactor of StateStoreCustomMetric
> ----------------------------------------
>
> Key: SPARK-35763
> URL: https://issues.apache.org/jira/browse/SPARK-35763
> Project: Spark
> Issue Type: Improvement
> Components: Structured Streaming
> Affects Versions: 3.1.2
> Reporter: Venki Korukanti
> Assignee: Venki Korukanti
> Priority: Trivial
> Fix For: 3.2.0
>
>
> Code in
> {{[SymmetricHashJoinStateManager|https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala#L321]}}
> relies on the subclass implementations of
> [StateStoreCustomMetric|https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala#L187].
> If a new subclass of {{StateStoreCustomMetric}} is added, it requires code
> changes to {{SymmetricHashJoinStateManager}} and we may miss the update if
> there is no existing test coverage.
> To fix this, add new method to trait {{withNewDesc(desc : String)}} to
> {{StateStoreCustomMetric}} and use it in {{SymmetricHashJoinStateManager}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
