[
https://issues.apache.org/jira/browse/SPARK-31646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17415740#comment-17415740
]
Yongjun Zhang edited comment on SPARK-31646 at 9/15/21, 8:27 PM:
-----------------------------------------------------------------
HI [~mauzhang], [~dongjoon], [~marek.simunek],
Thanks for your work here. SPARK-18364 (Thanks to [~marek.simunek]) intended to
create the registeredConnections metrics but reverted by this Jira here with
comment:
{quote}It's {{registeredConnections}} counter created in {{TransportContext}}
that's really counting the numbers and it's misleading for people who want to
add new metrics like {{registeredConnections}}.
{quote}
Could you please elaborate why the original one won't work? How would you all
define {{registeredConnections?}}
I'm looking into adding a metrics to report the backlogged connections to
shuffle service. If feels "registeredConenctions - activeConnections" would be
the backlogged connections.
Thanks.
was (Author: yzhangal):
HI [~mauzhang], [~dongjoon], [~marek.simunek],
Thanks for your work here. SPARK-18364 (Thanks to [~marek.simunek]) intended to
create the registeredConnections metrics but reverted by this Jira here with
comment:
{quote}
It's {{registeredConnections}} counter created in {{TransportContext}} that's
really counting the numbers and it's misleading for people who want to add new
metrics like {{registeredConnections}}.
{quote}
Could you please elaborate why the original one won't work? How would you all
define {{registeredConnections?}}
I'm looking into adding a metrics to report the backlogged connections to
shuffle service. If feels "registeredConenctions - activeConnections" would be
the backlogged connections.
Thanks.
> Remove unused registeredConnections counter from ShuffleMetrics
> ---------------------------------------------------------------
>
> Key: SPARK-31646
> URL: https://issues.apache.org/jira/browse/SPARK-31646
> Project: Spark
> Issue Type: Improvement
> Components: Deploy, Shuffle, Spark Core
> Affects Versions: 3.0.0
> Reporter: Manu Zhang
> Assignee: Manu Zhang
> Priority: Minor
> Fix For: 3.0.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
