Nadav Samet created SPARK-38077:
-----------------------------------
Summary: Spark 3.2.1 breaks binary compatibility with Spark 3.2.0
Key: SPARK-38077
URL: https://issues.apache.org/jira/browse/SPARK-38077
Project: Spark
Issue Type: Bug
Components: Spark Core
Affects Versions: 3.2.1, 3.2.0
Reporter: Nadav Samet
[PR 35243|https://github.com/apache/spark/pull/35243] introduced a new
parameter to class `Invoke` with a default value (`isDeterministic: Boolean =
true`). Existing Spark libraries (such as
[frameless|https://github.com/typelevel/frameless) that invoke
[Invoke|https://github.com/typelevel/frameless/blob/29961d549e332dddf5cd711ef699dde7460cc48a/dataset/src/main/scala/frameless/RecordEncoder.scala#L154]
directly expect a method with 7 parameters, and the new version expects 8. If
Frameless would recompile with Spark 3.2.1, the updated library will NOT be
binary compatible with Spark 3.2.0. Adding default parameters to existing
methods [should be
avoided|https://github.com/jatcwang/binary-compatibility-guide#dont-adding-parameters-with-default-values-to-methods].
One way forward would be to revert the change in the constructor and introduce
a second constructor or a companion method that takes all the 8 parameters.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
