[
https://issues.apache.org/jira/browse/SPARK-38725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Max Gekk updated SPARK-38725:
-----------------------------
Description:
Add at least one test for the error class *DUPLICATE_KEY* to
QueryParsingErrorsSuite. The test should cover the exception throw in
QueryParsingErrors:
{code:scala}
def duplicateKeysError(key: String, ctx: ParserRuleContext): Throwable = {
// Found duplicate keys '$key'
new ParseException(errorClass = "DUPLICATE_KEY", messageParameters =
Array(key), ctx)
}
{code}
For example, here is a test for the error class *UNSUPPORTED_FEATURE*:
https://github.com/apache/spark/blob/34e3029a43d2a8241f70f2343be8285cb7f231b9/sql/core/src/test/scala/org/apache/spark/sql/errors/QueryCompilationErrorsSuite.scala#L151-L170
+The test must have a check of:+
# the entire error message
# sqlState if it is defined in the error-classes.json file
# the error class
was:
Add at least one test for the error class *DIVIDE_BY_ZERO* to
QueryExecutionErrorsSuite. The test should cover the exception throw in
QueryExecutionErrors:
{code:scala}
def divideByZeroError(): ArithmeticException = {
new SparkArithmeticException(
errorClass = "DIVIDE_BY_ZERO", messageParameters =
Array(SQLConf.ANSI_ENABLED.key))
}
{code}
For example, here is a test for the error class *UNSUPPORTED_FEATURE*:
https://github.com/apache/spark/blob/34e3029a43d2a8241f70f2343be8285cb7f231b9/sql/core/src/test/scala/org/apache/spark/sql/errors/QueryCompilationErrorsSuite.scala#L151-L170
+The test must have a check of:+
# the entire error message
# sqlState if it is defined in the error-classes.json file
# the error class
> Test the error class: DUPLICATE_KEY
> -----------------------------------
>
> Key: SPARK-38725
> URL: https://issues.apache.org/jira/browse/SPARK-38725
> Project: Spark
> Issue Type: Sub-task
> Components: SQL
> Affects Versions: 3.4.0
> Reporter: Max Gekk
> Priority: Minor
> Labels: starter
>
> Add at least one test for the error class *DUPLICATE_KEY* to
> QueryParsingErrorsSuite. The test should cover the exception throw in
> QueryParsingErrors:
> {code:scala}
> def duplicateKeysError(key: String, ctx: ParserRuleContext): Throwable = {
> // Found duplicate keys '$key'
> new ParseException(errorClass = "DUPLICATE_KEY", messageParameters =
> Array(key), ctx)
> }
> {code}
> For example, here is a test for the error class *UNSUPPORTED_FEATURE*:
> https://github.com/apache/spark/blob/34e3029a43d2a8241f70f2343be8285cb7f231b9/sql/core/src/test/scala/org/apache/spark/sql/errors/QueryCompilationErrorsSuite.scala#L151-L170
> +The test must have a check of:+
> # the entire error message
> # sqlState if it is defined in the error-classes.json file
> # the error class
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
