[ 
https://issues.apache.org/jira/browse/SPARK-6369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372397#comment-14372397
 ] 

Yin Huai commented on SPARK-6369:
---------------------------------

Three places that need to be fixed are 
[hiveWriterContainer|https://github.com/apache/spark/blob/v1.3.0/sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveWriterContainers.scala#L120],
 
[newParquet|https://github.com/apache/spark/blob/v1.3.0/sql/core/src/main/scala/org/apache/spark/sql/parquet/newParquet.scala#L619],
 and [old parquet code 
path|https://github.com/apache/spark/blob/v1.3.0/sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTableOperations.scala#L342].
 We should follow the fix of SPARK-4879 
([here|https://github.com/apache/spark/blob/v1.3.0/core/src/main/scala/org/apache/spark/SparkHadoopWriter.scala#L106]).

Also, seems we can remove [this 
line|https://github.com/apache/spark/blob/v1.3.0/sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala#L75].



> InsertIntoHiveTable should use logic from SparkHadoopWriter
> -----------------------------------------------------------
>
>                 Key: SPARK-6369
>                 URL: https://issues.apache.org/jira/browse/SPARK-6369
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>            Reporter: Michael Armbrust
>            Priority: Critical
>
> Right now it is possible that we will corrupt the output if there is a race 
> between competing speculative tasks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to