[
https://issues.apache.org/jira/browse/SPARK-44039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herman van Hövell resolved SPARK-44039.
---------------------------------------
Fix Version/s: 3.5.0
Resolution: Fixed
> Improve for PlanGenerationTestSuite & ProtoToParsedPlanTestSuite
> ----------------------------------------------------------------
>
> Key: SPARK-44039
> URL: https://issues.apache.org/jira/browse/SPARK-44039
> Project: Spark
> Issue Type: Improvement
> Components: Connect, Tests
> Affects Versions: 3.5.0
> Reporter: BingKun Pan
> Assignee: BingKun Pan
> Priority: Minor
> Fix For: 3.5.0
>
>
> Improve for PlanGenerationTestSuite & ProtoToParsedPlanTestSuite, include:
> - When generating `GOLDEN` files, we should first delete the corresponding
> directories and generate new ones to avoid submitting some redundant files
> during the review process. eg:
> When we write a test named `make_timestamp_ltz` for the overloaded method,
> and during the review process, the reviewer wishes to add more tests for the
> method. The name of this method has changed during the next submission
> process, such as `make_timestamp_ltz without timezone`.At this point, if the
> `queries/function_make_timestamp_ltz.json`,
> `queries/function_make_timestamp_ltz.proto.bin` and
> `explain-results/function_make_timestamp_ltz.explain` files of
> `function_make_timestamp_ltz` are already in the commit, and there are many
> of these files, we generally do not notice the above problem, which leads to
> the incorrect submission of `queries/function_make_timestamp_ltz.json`,
> `queries/function_make_timestamp_ltz.proto.bin` and
> `explain-results/function_make_timestamp_ltz.explain` files without any
> impact on UT. These files are redundant.
> - Clear and update some redundant files submitted incorrectly
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
