[
https://issues.apache.org/jira/browse/SPARK-6773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485156#comment-14485156
]
Apache Spark commented on SPARK-6773:
-------------------------------------
User 'sisihj' has created a pull request for this issue:
https://github.com/apache/spark/pull/5421
> check -license will passed in next time when rat jar download failed.
> ---------------------------------------------------------------------
>
> Key: SPARK-6773
> URL: https://issues.apache.org/jira/browse/SPARK-6773
> Project: Spark
> Issue Type: Bug
> Components: Build
> Affects Versions: 1.3.0
> Reporter: June
>
> In dev/check-license, it will download Rat jar if it not exist. if download
> failed, it will report error:
> **************************
> Attempting to fetch rat
> Our attempt to download rat locally to
> /home/spark/hejun/sparkgit/spark/lib/apache-rat-0.10.jar failed. Please
> install rat manually.
> *****************************
> but if run it again in next cycle, it will check RAT passed and go on
> building also an error reported:
> **************************
> Error: Invalid or corrupt jarfile
> /home/spark/hejun/sparkgit/spark/lib/apache-rat-0.10.jar
> RAT checks passed.
> *****************************
> This is because:
> 1. The error tmp rat.jar is not removed when rat jar download failed in last
> time. So it will go on checking license using the error rat.jar
> 2. The rat-results.txt is empty because rat.jar run failed, so RAT check
> passed.
> Suggest:
> 1. Add a clean step when rat.jar download faild.
> 2. Add a error checking logic after run rat checking.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
