[ 
https://issues.apache.org/jira/browse/SPARK-46644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wenchen Fan resolved SPARK-46644.
---------------------------------
    Fix Version/s: 4.0.0
       Resolution: Fixed

Issue resolved by pull request 44649
[https://github.com/apache/spark/pull/44649]

> Fix add in SQLMetric
> --------------------
>
>                 Key: SPARK-46644
>                 URL: https://issues.apache.org/jira/browse/SPARK-46644
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 3.5.0
>            Reporter: Davin Tjong
>            Assignee: Davin Tjong
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>
> A previous refactor mistakenly used `isValid` for add. Since 
> `defaultValidValue` was always `0`, this didn't cause any correctness issues.
> What we really want to do for add (and merge) is `if (isZero) _value = 0`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to