[
https://issues.apache.org/jira/browse/SPARK-57216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18085867#comment-18085867
]
Gengliang Wang commented on SPARK-57216:
----------------------------------------
Flagging against the scope guidance added to the umbrella SPARK-56908.
This is a source-only dead-branch elimination: Janino constant-folds {{if
(true)}} / {{if (false)}}, so there is no bytecode change. Measured on TPC-DS
whole-stage codegen, even the most frequent such patterns (x358-445, ~0.4% of
generated source) saved compile time below the run-to-run noise floor (~0.7%).
The changes that _were_ worth it removed more than source -- e.g. SPARK-57198
dropped an unreachable {{references[]}} / constant-pool entry, which Janino
cannot recover.
Before merging, please confirm this removes more than source text (a
{{references[]}} / constant-pool entry, or keeps a method under the 64KB limit)
-- raw occurrence count alone is not sufficient. If not, it adds codegen-logic
complexity for negligible benefit and should be dropped.
> Skip dead null-check branches in NaNvl codegen for non-nullable children
> ------------------------------------------------------------------------
>
> Key: SPARK-57216
> URL: https://issues.apache.org/jira/browse/SPARK-57216
> Project: Spark
> Issue Type: Sub-task
> Components: SQL
> Affects Versions: 4.3.0
> Reporter: Yang Jie
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
