Uroš Bojanić created SPARK-58760:
------------------------------------

             Summary: Use consistent colName interpolation in CatalogColumnStat
                 Key: SPARK-58760
                 URL: https://issues.apache.org/jira/browse/SPARK-58760
             Project: Spark
          Issue Type: Improvement
          Components: SQL
    Affects Versions: 4.3.0
            Reporter: Uroš Bojanić


CatalogColumnStat.toMap and fromMap build the table-property keys for column 
statistics by interpolating the column name and a key constant, and they mix 
${colName} with the bare $colName for the same value, including on adjacent 
lines (the histogram key already uses $colName).

This unbraces the 14 remaining ${colName} occurrences to $colName, matching the 
file's own dominant style. The qualified selects such as 
${CatalogColumnStat.KEY_VERSION} keep their braces, since dropping those would 
interpolate the object and append the member name as literal text.

Behavior is unchanged: in every case colName is a simple parameter immediately 
followed by a dot, so $colName. parses identically to ${colName}. and the 
generated property keys are byte-for-byte the same, preserving metadata 
compatibility.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to