Luka Zdravic created SPARK-59890:
------------------------------------
Summary: Replace ResolveAsOfJoinSuite with end-to-end ASOF JOIN
tests
Key: SPARK-59890
URL: https://issues.apache.org/jira/browse/SPARK-59890
Project: Spark
Issue Type: Test
Components: SQL
Affects Versions: 4.4.0
Reporter: Luka Zdravic
ResolveAsOfJoinSuite unit-tests only the fixed-point analyzer rule
ResolveAsOfJoin. It builds plans by hand and checks internal expression shapes,
for example that the MATCH_CONDITION distance is a Subtract or a ZipWith.
This has two problems:
- It does not test the single-pass resolver (AsOfJoinResolver), which shares
the same MATCH_CONDITION code.
- It pins internal shapes, so an internal change to MATCH_CONDITION must edit
it even when no query result changes. SPARK-59749 had to.
End-to-end tests already cover ASOF JOIN analysis: the golden files
join-asof-*.sql, AsOfJoinSQLSuite, and AsOfJoinSortMergeSQLSuite. In tests,
these queries run both analyzers where the single-pass resolver supports them,
and fail if the plans differ
(spark.sql.analyzer.singlePassResolver.dualRunWithLegacy is on while testing).
Proposal: remove ResolveAsOfJoinSuite. Add golden cases for any behavior that
only this suite checks. Test-only change.
Umbrella: SPARK-59526
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
