DB Tsai created SPARK-61090:
-------------------------------

             Summary: Harden reattach cleanup regression tests in Spark Connect 
Rust
                 Key: SPARK-61090
                 URL: https://issues.apache.org/jira/browse/SPARK-61090
             Project: Spark
          Issue Type: Test
          Components: Connect
    Affects Versions: connect-rust-4.3.0
            Reporter: DB Tsai
             Fix For: connect-rust-4.3.0


The loopback gRPC tests added by SPARK-60966 / PR #172 cover reattachable 
execution cleanup, but leave several request-propagation and failure-path 
contracts unobserved. Harden that fixture so regressions produce direct, 
independently named test failures.

* Verify ExecutePlan identity, reattachable options, authentication and custom 
headers, and verify identity and headers on ReattachExecute.
* Exercise INTERNAL / INVALID_CURSOR.DISCONNECTED and a permanent 
PermissionDenied reattach failure. Check error details, cleanup while the 
stream remains alive, and absence of retry or duplicate release requests.
* Split combined scenarios into named tests, bound outside-runtime Drop 
completion with an asynchronous signal, and report excess release counts 
directly.

This changes only regression tests. No production defect or user-facing 
behavior change was demonstrated.

Implementation: https://github.com/apache/spark-connect-rust/pull/284
Original coverage: https://github.com/apache/spark-connect-rust/pull/172

The full patch received independent Claude Code source review, and git diff 
--check passed. Rust tests and formatting could not run locally because the 
Rust/Cargo toolchain was unavailable; these are not claimed as local passes.




--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to