[ 
https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14594227#comment-14594227
 ] 

Yu Ishikawa commented on SPARK-6813:
------------------------------------

[~shivaram] Those two rules looks good!

I modified my code, using the github version instead of the CRAN version. And I 
tryied to set the two rules in it.

h3. The latest version script

https://github.com/apache/spark/compare/master...yu-iskw:SPARK-6813

h3. The result of the script

https://gist.github.com/yu-iskw/7a663dbea295ee767849

h3. Rules we should discuss

- {{Variable and function names should be all lowercase}} or not
- {{Trailing whitespace is superfluous}}


> SparkR style guide
> ------------------
>
>                 Key: SPARK-6813
>                 URL: https://issues.apache.org/jira/browse/SPARK-6813
>             Project: Spark
>          Issue Type: New Feature
>          Components: SparkR
>            Reporter: Shivaram Venkataraman
>
> We should develop a SparkR style guide document based on the some of the 
> guidelines we use and some of the best practices in R.
> Some examples of R style guide are:
> http://r-pkgs.had.co.nz/r.html#style 
> http://google-styleguide.googlecode.com/svn/trunk/google-r-style.html
> A related issue is to work on a automatic style checking tool. 
> https://github.com/jimhester/lintr seems promising
> We could have a R style guide based on the one from google [1], and adjust 
> some of them with the conversation in Spark:
> 1. Line Length: maximum 100 characters
> 2. no limit on function name (API should be similar as in other languages)
> 3. Allow S4 objects/methods



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to