[ 
https://issues.apache.org/jira/browse/SPARK-8372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601580#comment-14601580
 ] 

Marcelo Vanzin commented on SPARK-8372:
---------------------------------------

Just leaving here the comment I left in the PR after this was fixed:

So, one thing that I noticed after I said "LGTM" is that this change breaks old 
logs (those generated by versions of Spark that do not record the app id). 
Those will never show up anymore (I think that should only be Spark 1.0?).

If we care about that use case, this version should probably be reverted. The 
proper fix could be something as simple as this:

{code}
appListener.appId.getOrElse(logPath.getName().stripSuffix(EventLoggingListener.IN_PROGRESS)),
{code}


> History server shows incorrect information for application not started
> ----------------------------------------------------------------------
>
>                 Key: SPARK-8372
>                 URL: https://issues.apache.org/jira/browse/SPARK-8372
>             Project: Spark
>          Issue Type: Bug
>          Components: Deploy, Web UI
>    Affects Versions: 1.4.0
>            Reporter: Carson Wang
>            Assignee: Carson Wang
>            Priority: Minor
>             Fix For: 1.4.1, 1.5.0
>
>         Attachments: IncorrectAppInfo.png
>
>
> The history server may show an incorrect App ID for an incomplete application 
> like <App ID>.inprogress. This app info will never disappear even after the 
> app is completed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to