[ 
https://issues.apache.org/jira/browse/SPARK-8872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiangrui Meng updated SPARK-8872:
---------------------------------
    Description: In `FPGrowthSuite`, we only tested output with minSupport 0.5, 
where the expected output is hard-coded. We can add equivalent R code using the 
arules package to generate the expect output for validation purpose, similar to 
https://github.com/apache/spark/blob/master/mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala#L98
 and the test code in https://github.com/apache/spark/pull/7005.  (was: In 
`FPGrowthSuite`, we only tested output with minSupport 0.5, where the expected 
output is hard-coded. We can add equivalent R code to generate the expect 
output for validation purpose, similar to 
https://github.com/apache/spark/blob/master/mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala#L98.)

> Improve FPGrowthSuite with equivalent R code
> --------------------------------------------
>
>                 Key: SPARK-8872
>                 URL: https://issues.apache.org/jira/browse/SPARK-8872
>             Project: Spark
>          Issue Type: Improvement
>          Components: MLlib
>    Affects Versions: 1.4.0
>            Reporter: Xiangrui Meng
>            Priority: Minor
>              Labels: starter
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> In `FPGrowthSuite`, we only tested output with minSupport 0.5, where the 
> expected output is hard-coded. We can add equivalent R code using the arules 
> package to generate the expect output for validation purpose, similar to 
> https://github.com/apache/spark/blob/master/mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala#L98
>  and the test code in https://github.com/apache/spark/pull/7005.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to