[
https://issues.apache.org/jira/browse/SPARK-9053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636060#comment-14636060
]
Shivaram Venkataraman commented on SPARK-9053:
----------------------------------------------
Yeah - there are a bunch of real issues to be fixed first and we can discuss
the ignore rule after that. Also I don't think we should ignore all warnings of
this form -- just say on the `^` operator or we can mark out portions of the
code that need to be ignored etc.
> Fix spaces around parens, infix operators etc.
> ----------------------------------------------
>
> Key: SPARK-9053
> URL: https://issues.apache.org/jira/browse/SPARK-9053
> Project: Spark
> Issue Type: Sub-task
> Components: SparkR
> Reporter: Shivaram Venkataraman
>
> We have a number of style errors which look like
> {code}
> Place a space before left parenthesis
> ...
> Put spaces around all infix operators.
> {code}
> However some of the warnings are spurious (example space around infix
> operator in
> {code}
> expect_equal(collect(select(df, hypot(df$a, df$b)))[4, "HYPOT(a, b)"],
> sqrt(4^2 + 8^2))
> {code}
> We should add a ignore rule for these spurious examples
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
