[
https://issues.apache.org/jira/browse/SPARK-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662317#comment-14662317
]
Feynman Liang edited comment on SPARK-9660 at 8/7/15 8:04 PM:
--------------------------------------------------------------
Should [RandomForestClassificationModel's aux
constructor|https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala#L139]
be private? Ditto for
[DecisionTreeRegressionModel|https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala#L110],
[RandomForestRegressionModel|https://github.com/apache/spark/blob/9897cc5e3d6c70f7e45e887e2c6fc24dfa1adada/mllib/src/main/scala/org/apache/spark/ml/regression/RandomForestRegressor.scala#L128]
was (Author: fliang):
Should [RandomForestClassificationModel's aux
constructor|https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala#L139]
be private? Ditto for
[DecisionTreeRegressionModel|https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala#L110],
[RandomForestRegressionModel|https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala#L110]
> ML 1.5 QA: API: New Scala APIs, docs
> ------------------------------------
>
> Key: SPARK-9660
> URL: https://issues.apache.org/jira/browse/SPARK-9660
> Project: Spark
> Issue Type: Sub-task
> Components: Documentation, ML, MLlib
> Reporter: Joseph K. Bradley
>
> Audit new public Scala APIs added to MLlib. Take note of:
> * Protected/public classes or methods. If access can be more private, then
> it should be.
> * Also look for non-sealed traits.
> * Documentation: Missing? Bad links or formatting?
> *Make sure to check the object doc!*
> As you find issues, please comment here, or better yet create JIRAs and link
> them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
