[ 
https://issues.apache.org/jira/browse/SPARK-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662358#comment-14662358
 ] 

Joseph K. Bradley commented on SPARK-9660:
------------------------------------------

I want to add it as public for all PredictionModel types eventually, so I don't 
see harm in leaving it public.

> ML 1.5 QA: API: New Scala APIs, docs
> ------------------------------------
>
>                 Key: SPARK-9660
>                 URL: https://issues.apache.org/jira/browse/SPARK-9660
>             Project: Spark
>          Issue Type: Sub-task
>          Components: Documentation, ML, MLlib
>            Reporter: Joseph K. Bradley
>
> Audit new public Scala APIs added to MLlib.  Take note of:
> * Protected/public classes or methods.  If access can be more private, then 
> it should be.
> * Also look for non-sealed traits.
> * Documentation: Missing?  Bad links or formatting?
> *Make sure to check the object doc!*
> As you find issues, please comment here, or better yet create JIRAs and link 
> them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to