[ 
https://issues.apache.org/jira/browse/SPARK-9644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14701202#comment-14701202
 ] 

Pete Robbins commented on SPARK-9644:
-------------------------------------

This change makes assumptions about the implementation of BigInteger such as 
field names and their contents. This may work with the current OpenJDK 
implementation but is not guaranteed to work in the future. Also this causes an 
abort on IBM jdks as it has a different underlying implementation of BigInteger

The code should not access the private fields signum and mag but should use the 
defined Java API methods signum() and toByteArray() to extract the required 
values.

I can create a patch to correct this.

> Support update DecimalType with precision > 18 in UnsafeRow
> -----------------------------------------------------------
>
>                 Key: SPARK-9644
>                 URL: https://issues.apache.org/jira/browse/SPARK-9644
>             Project: Spark
>          Issue Type: Improvement
>    Affects Versions: 1.5.0
>            Reporter: Davies Liu
>            Assignee: Davies Liu
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> Currently, we don't support using DecimalType with precision > 18 in new 
> unsafe aggregation, it's good to support it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to