[ 
https://issues.apache.org/jira/browse/SPARK-10104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yin Huai updated SPARK-10104:
-----------------------------
    Description: 
Right now, we have QualifiedTableName, TableIdentifier, and Seq[String] to 
represent table identifiers. We should only have one form and looks 
TableIdentifier is the best one because it provides methods to get table name, 
database name, return unquoted string, and return quoted string. 

Also, we need to refactor commands CreateTableUsing, CreateTableUsingAsSelect, 
CreateMetastoreDataSource, and CreateMetastoreDataSourceAsSelect to take a 
TableIdentifier instead of a plan string. So we do not need to parse the table 
name again in HiveMetastoreCatalog's createDataSourceTable, 
CreateMetastoreDataSource, or CreateMetastoreDataSourceAsSelect.

  was:
Right now, we have QualifiedTableName, TableIdentifier, and Seq[String] to 
represent table identifiers. We should only have one form and looks 
TableIdentifier is the best one because it provides methods to get table name, 
database name, return unquoted string, and return quoted string. 

Also, we need to refactor commands CreateTableUsing, CreateTableUsingAsSelect, 
CreateMetastoreDataSource, and CreateMetastoreDataSourceAsSelect to take a 
TableIdentifier instead of a plan string. So we do not need to parse the table 
name again in HiveMetastoreCatalog's createDataSourceTable.


> Consolidate different forms of table identifiers
> ------------------------------------------------
>
>                 Key: SPARK-10104
>                 URL: https://issues.apache.org/jira/browse/SPARK-10104
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>            Reporter: Yin Huai
>
> Right now, we have QualifiedTableName, TableIdentifier, and Seq[String] to 
> represent table identifiers. We should only have one form and looks 
> TableIdentifier is the best one because it provides methods to get table 
> name, database name, return unquoted string, and return quoted string. 
> Also, we need to refactor commands CreateTableUsing, 
> CreateTableUsingAsSelect, CreateMetastoreDataSource, and 
> CreateMetastoreDataSourceAsSelect to take a TableIdentifier instead of a plan 
> string. So we do not need to parse the table name again in 
> HiveMetastoreCatalog's createDataSourceTable, CreateMetastoreDataSource, or 
> CreateMetastoreDataSourceAsSelect.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to