Feynman Liang created SPARK-10478: ------------------------------------- Summary: Improve spark.ml.ann implementations for MLP Key: SPARK-10478 URL: https://issues.apache.org/jira/browse/SPARK-10478 Project: Spark Issue Type: Bug Components: ML Reporter: Feynman Liang Priority: Critical
SPARK-9471 adds an implementation of multi-layer perceptrons. However, there are a few issues with the current code that should be addressed, namely: * Style guide: 4 indent method arguments, braces around one-line {{if}}s, punctuation in scaladocs * Comments: cryptic variable names (e.g. {{gw}}, {{gb}}, {{gwb}}) should be documented * Performance: parts of the code can be improved using Breeze broadcasts, vectorized operations, and Breeze UFuncs to avoid manual iteration and leverage BLAS optimization -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org