[
https://issues.apache.org/jira/browse/SPARK-12177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074262#comment-15074262
]
Nikita Tarasenko commented on SPARK-12177:
------------------------------------------
Hi, Mario! Thank you for review! It very helpful for me.
I made a few commits based on your A-C comments and your implementation on
github repo:
-
https://github.com/nikit-os/spark/commit/44bb56806ab5fb86d0e27ed8108188c5808bae0f
-
https://github.com/nikit-os/spark/commit/85fad9410ab5133bd92e01af278e2f473c07b745
-
https://github.com/nikit-os/spark/commit/2d36c76f1bc8bcba59261d37bbff90e67ece73d7
About 'D' comment - kafka-core needed not only for TopicAndPartition class but
for some classes (such as KafkaConfig, ZkUtils, KafkaServer, Producer) that
needed for KafkaTestUtils. This is reason why I keep kafka-core dependency.
> Update KafkaDStreams to new Kafka 0.9 Consumer API
> --------------------------------------------------
>
> Key: SPARK-12177
> URL: https://issues.apache.org/jira/browse/SPARK-12177
> Project: Spark
> Issue Type: Improvement
> Components: Streaming
> Affects Versions: 1.6.0
> Reporter: Nikita Tarasenko
> Labels: consumer, kafka
>
> Kafka 0.9 already released and it introduce new consumer API that not
> compatible with old one. So, I added new consumer api. I made separate
> classes in package org.apache.spark.streaming.kafka.v09 with changed API. I
> didn't remove old classes for more backward compatibility. User will not need
> to change his old spark applications when he uprgade to new Spark version.
> Please rewiew my changes
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
