[
https://issues.apache.org/jira/browse/SPARK-13085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles Allen updated SPARK-13085:
----------------------------------
Description:
As an occasional or new contributor, it is easy to screw up scala style. But
looking at the output logs (for example
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50300/consoleFull
) it is not obvious how to fix the scala style tests, even when reading the
scala style guide.
{code}
========================================================================
Running Scala style checks
========================================================================
Scalastyle checks failed at following occurrences:
[error]
/home/jenkins/workspace/SparkPullRequestBuilder/core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala:22:0:
import.ordering.wrongOrderInGroup.message
[error] (core/compile:scalastyle) errors exist
[error] Total time: 9 s, completed Jan 28, 2016 2:11:00 PM
[error] running /home/jenkins/workspace/SparkPullRequestBuilder/dev/lint-scala
; received return code 1
{code}
This ask is that the command used to check scalastyle is presented in the log
so a developer does not have to wait for the build process to check if a pull
request should pass scala style checks.
was:
As an occasional or new contributor, it is easy to screw up scala style. But
looking at the output logs (for example
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50300/consoleFull
) it is not obvious how to fix the scala style tests, even when reading the
scala guide.
{code}
========================================================================
Running Scala style checks
========================================================================
Scalastyle checks failed at following occurrences:
[error]
/home/jenkins/workspace/SparkPullRequestBuilder/core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala:22:0:
import.ordering.wrongOrderInGroup.message
[error] (core/compile:scalastyle) errors exist
[error] Total time: 9 s, completed Jan 28, 2016 2:11:00 PM
[error] running /home/jenkins/workspace/SparkPullRequestBuilder/dev/lint-scala
; received return code 1
{code}
This ask is that the command used to check scalastyle is presented in the log
so a developer does not have to wait for the build process to check if a pull
request should pass scala style checks.
> Add scalastyle command used in build testing
> --------------------------------------------
>
> Key: SPARK-13085
> URL: https://issues.apache.org/jira/browse/SPARK-13085
> Project: Spark
> Issue Type: Wish
> Components: Build, Tests
> Reporter: Charles Allen
>
> As an occasional or new contributor, it is easy to screw up scala style. But
> looking at the output logs (for example
> https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50300/consoleFull
> ) it is not obvious how to fix the scala style tests, even when reading the
> scala style guide.
> {code}
> ========================================================================
> Running Scala style checks
> ========================================================================
> Scalastyle checks failed at following occurrences:
> [error]
> /home/jenkins/workspace/SparkPullRequestBuilder/core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala:22:0:
> import.ordering.wrongOrderInGroup.message
> [error] (core/compile:scalastyle) errors exist
> [error] Total time: 9 s, completed Jan 28, 2016 2:11:00 PM
> [error] running
> /home/jenkins/workspace/SparkPullRequestBuilder/dev/lint-scala ; received
> return code 1
> {code}
> This ask is that the command used to check scalastyle is presented in the log
> so a developer does not have to wait for the build process to check if a pull
> request should pass scala style checks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
