[ 
https://issues.apache.org/jira/browse/SPARK-12718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181973#comment-15181973
 ] 

Xiao Li commented on SPARK-12718:
---------------------------------

Just confirmed that no optimizer rule needs to be added. 
{code}
SELECT  t.p_mfgr, 
        t.p_name, 
        t.p_size, 
        t.dr, 
        rank() OVER (distribute BY p_mfgr sort BY p_name, p_mfgr) AS r 
FROM    ( 
                SELECT  p_mfgr, 
                        p_name, 
                        p_size, 
                        dense_rank() OVER (distribute BY p_mfgr sort BY p_name) 
AS dr 
                FROM    part) t
{code}

{code}
== Analyzed Logical Plan ==
p_mfgr: string, p_name: string, p_size: int, dr: int, r: int
Project [p_mfgr#60,p_name#59,p_size#63,dr#28,r#29]
+- Project [p_mfgr#60,p_name#59,p_size#63,dr#28,r#29,r#29]
   +- Window [p_mfgr#60,p_name#59,p_size#63,dr#28], [rank(p_name#59, p_mfgr#60) 
windowspecdefinition(p_mfgr#60, p_name#59 ASC, p_mfgr#60 ASC, ROWS BETWEEN 
UNBOUNDED PRECEDING AND CURRENT ROW) AS r#29], [p_mfgr#60], [p_name#59 
ASC,p_mfgr#60 ASC]
      +- Project [p_mfgr#60,p_name#59,p_size#63,dr#28]
         +- SubqueryAlias t
            +- Project [p_mfgr#60,p_name#59,p_size#63,dr#28]
               +- Project [p_mfgr#60,p_name#59,p_size#63,dr#28,dr#28]
                  +- Window [p_mfgr#60,p_name#59,p_size#63], 
[denserank(p_name#59) windowspecdefinition(p_mfgr#60, p_name#59 ASC, ROWS 
BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW) AS dr#28], [p_mfgr#60], [p_name#59 
ASC]
                     +- Project [p_mfgr#60,p_name#59,p_size#63]
                        +- MetastoreRelation default, part, None
{code}

{code}
== Optimized Logical Plan ==
Window [p_mfgr#60,p_name#59,p_size#63,dr#28], [rank(p_name#59, p_mfgr#60) 
windowspecdefinition(p_mfgr#60, p_name#59 ASC, p_mfgr#60 ASC, ROWS BETWEEN 
UNBOUNDED PRECEDING AND CURRENT ROW) AS r#29], [p_mfgr#60], [p_name#59 
ASC,p_mfgr#60 ASC]
+- Window [p_mfgr#60,p_name#59,p_size#63], [denserank(p_name#59) 
windowspecdefinition(p_mfgr#60, p_name#59 ASC, ROWS BETWEEN UNBOUNDED PRECEDING 
AND CURRENT ROW) AS dr#28], [p_mfgr#60], [p_name#59 ASC]
   +- Project [p_mfgr#60,p_name#59,p_size#63]
      +- MetastoreRelation default, part, None
{code}


> SQL generation support for window functions
> -------------------------------------------
>
>                 Key: SPARK-12718
>                 URL: https://issues.apache.org/jira/browse/SPARK-12718
>             Project: Spark
>          Issue Type: Sub-task
>          Components: SQL
>    Affects Versions: 2.0.0
>            Reporter: Cheng Lian
>            Assignee: Xiao Li
>
> {{HiveWindowFunctionQuerySuite}} and {{HiveWindowFunctionQueryFileSuite}} can 
> be useful for bootstrapping test coverage. Please refer to SPARK-11012 for 
> more details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to