[ https://issues.apache.org/jira/browse/SPARK-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dongjoon Hyun updated SPARK-13692: ---------------------------------- Description: This issue fixes the following potential bugs and Java coding style detected by Coverity and Checkstyle. * Implement both null and type checking in equals functions. * Fix wrong type casting logic in SimpleJavaBean2.equals. * Add `implement Cloneable` to `UTF8String` and `SortedIterator`. * Remove dereferencing before null check in `AbstractBytesToBytesMapSuite`. * Fix coding style: Add '{}' to single `for` statement in mllib examples. * Remove unused imports in `ColumnarBatch` and `JavaKinesisStreamSuite.java`. * Remove unused fields in `ChunkFetchIntegrationSuite`. * Add `stop()` to prevent resource leak. Please note that the last two checkstyle errors exist on newly added commits after [SPARK-13583]. was: This issue fixes the following potential bugs and Java coding style detected by Coverity and Checkstyle. * Implement both null and type checking in equals functions. * Fix wrong type casting logic in SimpleJavaBean2.equals. * Add `implement Cloneable` to `UTF8String` and `SortedIterator`. * Remove dereferencing before null check in `AbstractBytesToBytesMapSuite`. * Fix coding style: Add '{}' to single `for` statement in mllib examples. * Remove unused imports in `ColumnarBatch`. * Remove unused fields in `ChunkFetchIntegrationSuite`. * Add `stop()` to prevent resource leak. Please note that the last two checkstyle errors exist on newly added commits after [SPARK-13583]. > Fix trivial Coverity/Checkstyle defects > --------------------------------------- > > Key: SPARK-13692 > URL: https://issues.apache.org/jira/browse/SPARK-13692 > Project: Spark > Issue Type: Bug > Components: Examples, Spark Core, SQL > Reporter: Dongjoon Hyun > Priority: Trivial > > This issue fixes the following potential bugs and Java coding style detected > by Coverity and Checkstyle. > * Implement both null and type checking in equals functions. > * Fix wrong type casting logic in SimpleJavaBean2.equals. > * Add `implement Cloneable` to `UTF8String` and `SortedIterator`. > * Remove dereferencing before null check in `AbstractBytesToBytesMapSuite`. > * Fix coding style: Add '{}' to single `for` statement in mllib examples. > * Remove unused imports in `ColumnarBatch` and > `JavaKinesisStreamSuite.java`. > * Remove unused fields in `ChunkFetchIntegrationSuite`. > * Add `stop()` to prevent resource leak. > Please note that the last two checkstyle errors exist on newly added commits > after [SPARK-13583]. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org