[ 
https://issues.apache.org/jira/browse/SPARK-13986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200559#comment-15200559
 ] 

Dongjoon Hyun commented on SPARK-13986:
---------------------------------------

Oh, that's a great idea. For this, I found just regular-expression search in 
IntelliJ.

For style checking, we need to add a `ScalaStyle` rule and Maven CheckStyle 
rule since I've seen some `@DeveloperApi` in Java code, too.

By the way, Maven CheckStyle checking is not ran automatically as of today.

> Make `DeveloperApi`-annotated things public
> -------------------------------------------
>
>                 Key: SPARK-13986
>                 URL: https://issues.apache.org/jira/browse/SPARK-13986
>             Project: Spark
>          Issue Type: Improvement
>          Components: MLlib, Spark Core
>            Reporter: Dongjoon Hyun
>            Priority: Minor
>
> Spark uses `@DeveloperApi` annotation, but sometimes it seems to conflict 
> with its visibility. This issue proposes to fix those conflict. The following 
> is the example.
> {code:title=JobResult.scala|borderStyle=solid}
> @DeveloperApi
> sealed trait JobResult
> @DeveloperApi
> case object JobSucceeded extends JobResult
> @DeveloperApi
> -private[spark] case class JobFailed(exception: Exception) extends JobResult
> +case class JobFailed(exception: Exception) extends JobResult
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to