[ https://issues.apache.org/jira/browse/STORM-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jungtaek Lim resolved STORM-2184. --------------------------------- Resolution: Fixed Fix Version/s: 1.0.3 1.1.0 2.0.0 Thanks [~Srdo], I merged into master, 1.x, 1.0.x branches. > New Kafka spout will fail to commit offsets on shutdown if there are offsets > to commit > -------------------------------------------------------------------------------------- > > Key: STORM-2184 > URL: https://issues.apache.org/jira/browse/STORM-2184 > Project: Apache Storm > Issue Type: Bug > Reporter: Stig Rohde Døssing > Assignee: Stig Rohde Døssing > Priority: Trivial > Fix For: 2.0.0, 1.1.0, 1.0.3 > > Time Spent: 40m > Remaining Estimate: 0h > > As far as I know spout methods are not called concurrently by Storm. When the > new Kafka spout closes or deactivates, the closing thread calls > KafkaConsumer.wakeup. If there are uncommitted offsets and the spout is in > manual commit mode, it then tries to commit offsets. Since there are no other > threads concurrently interacting with the spout, the call to > KafkaConsumer.commitSync will end up throwing WakeupException. This is > because the behavior of wakeup is to cause the next blocking call to throw > WakeupException if there are no other threads blocking on the consumer when > wakeup is called. > The call to wakeup should be removed, since it does nothing if there are no > offsets to commit, and causes an uncaught exception if there are. -- This message was sent by Atlassian JIRA (v6.3.4#6332)