[
https://issues.apache.org/jira/browse/STORM-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15732959#comment-15732959
]
Robert Joseph Evans commented on STORM-2104:
--------------------------------------------
I merged the pull request into master branch, but it has some minor merge
conflicts and java 7 incompatibilities. If you want this to go into 1.1 you
will need to create a new pull request for that. Overall it is really good.
> New Kafka spout crashes if partitions are reassigned while tuples are
> in-flight
> -------------------------------------------------------------------------------
>
> Key: STORM-2104
> URL: https://issues.apache.org/jira/browse/STORM-2104
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-kafka
> Affects Versions: 2.0.0, 1.1.0
> Reporter: Stig Rohde Døssing
> Assignee: Stig Rohde Døssing
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The new KafkaSpout may throw NPEs if partitions are reassigned while tuples
> are in-flight. The ack function assumes that the spout instance is always
> responsible for tuples it emitted, which isn't true if partitions were
> reassigned since the tuple was emitted. The fail function also assumes that
> failed tuples should be replayed, which is useless if the tuple is for a
> partition the spout isn't assigned, since it then can't commit the tuple if
> it succeeds. Both functions should check that the spout instance is
> responsible for the incoming tuple before scheduling it for retry or adding
> it to the acked list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
