[
https://issues.apache.org/jira/browse/STORM-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869242#comment-15869242
]
Sachin Pasalkar commented on STORM-2358:
----------------------------------------
I think you are offended. Let talk it in community & then will decide.
For pt 2:
I still believe to have things generalise rather than having specific checks
For pt 3:
To answer your question developer (end user) will always know how many fields
it will be split into if he is not how even he is going to set in HDFSSpout?
For now I will keep this thing aside as its bigger change.
> Update storm hdfs spout to remove specific implementation handlings
> -------------------------------------------------------------------
>
> Key: STORM-2358
> URL: https://issues.apache.org/jira/browse/STORM-2358
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-hdfs
> Affects Versions: 1.x
> Reporter: Sachin Pasalkar
> Labels: newbie
> Attachments: AbstractFileReader.java, FileReader.java,
> HDFSSpout.java, SequenceFileReader.java, TextFileReader.java
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I was looking at storm hdfs spout code in 1.x branch, I found below
> improvements can be made in below code.
> 1. Make org.apache.storm.hdfs.spout.AbstractFileReader as public so
> that it can be used in generics.
> 2. org.apache.storm.hdfs.spout.HdfsSpout requires readerType as
> String. It will be great to have class<? extends AbstractFileReader>
> readerType; So we will not use Class.forName at multiple places also it
> will help in below point.
> 3. HdfsSpout also needs to provide outFields which are declared as
> constants in each reader(e.g.SequenceFileReader). We can have abstract
> API AbstractFileReader in which return them to user to make it generic.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
