[
https://issues.apache.org/jira/browse/STORM-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stig Rohde Døssing resolved STORM-2548.
---------------------------------------
Resolution: Fixed
> Simplify KafkaSpoutConfig
> -------------------------
>
> Key: STORM-2548
> URL: https://issues.apache.org/jira/browse/STORM-2548
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-kafka-client
> Affects Versions: 2.0.0, 1.1.0
> Reporter: Stig Rohde Døssing
> Assignee: Stig Rohde Døssing
> Fix For: 2.0.0, 1.2.0
>
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> Some suggestions for simplifying KafkaSpoutConfig off the mailing list:
> * We should not duplicate properties that users would normally set in the
> KafkaConsumer properties map. We should just have a setter (setProp) for
> setting properties in that map. For instance, setGroupId is just duplicating
> a setting that the user should be able to set directly in the consumer
> properties.
> * We should get rid of the key/value deserializer setters. Setting the
> deserializers as classes is something the user can just as well do by using
> setProp. The SerializableDeserializer class should be removed. It is only
> offering extra type safety in the case where the user is defining their own
> deserializer type, and has the opportunity to subclass
> SerializableDeserializer. The setters don't work with the built in Kafka
> deserializers.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
