[
https://issues.apache.org/jira/browse/STORM-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Dara updated STORM-2791:
-------------------------------
Description:
The class
[FixedTupleSpout|https://github.com/apache/storm/blob/64e29f365c9b5d3e15b33f33ab64e200345333e4/storm-client/src/jvm/org/apache/storm/testing/FixedTupleSpout.java#L34]
is useful for emitting test tuples in end-to-end topology tests. Unfortunately
it appears to only support a single output field, which greatly limits what
topologies you can test with.
In the PR, I propose adding a new constructor to FixedTupleSpout to allow
specifying more than one field.
I also decided to deprecate the existing constructor which accepts a String due
to the fact that it will cause an ambiguity compilation error if the calling
code is passing in null, so it should probably be entirely removed at a later
point.
I created a PR against master and against the 1.x branch.
was:
The class
[FixedTupleSpout|https://github.com/apache/storm/blob/64e29f365c9b5d3e15b33f33ab64e200345333e4/storm-client/src/jvm/org/apache/storm/testing/FixedTupleSpout.java#L34]
is useful for emitting test tuples in end-to-end topology tests. Unfortunately
it appears to only support a single output field, which greatly limits what
topologies you can test with.
In my PRs, I propose adding a new constructor to FixedTupleSpout to allow
specifying more than one field.
I also decided to deprecate the existing constructor which accepts a String due
to the fact that it will cause an ambiguity compilation error if the calling
code is passing in null, so it should probably be entirely removed at a later
point.
I created a PR against master and against the 1.x branch.
> Add support for multiple output fields to FixedTupleSpout
> ---------------------------------------------------------
>
> Key: STORM-2791
> URL: https://issues.apache.org/jira/browse/STORM-2791
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Daniel Dara
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The class
> [FixedTupleSpout|https://github.com/apache/storm/blob/64e29f365c9b5d3e15b33f33ab64e200345333e4/storm-client/src/jvm/org/apache/storm/testing/FixedTupleSpout.java#L34]
> is useful for emitting test tuples in end-to-end topology tests.
> Unfortunately it appears to only support a single output field, which greatly
> limits what topologies you can test with.
> In the PR, I propose adding a new constructor to FixedTupleSpout to allow
> specifying more than one field.
> I also decided to deprecate the existing constructor which accepts a String
> due to the fact that it will cause an ambiguity compilation error if the
> calling code is passing in null, so it should probably be entirely removed at
> a later point.
> I created a PR against master and against the 1.x branch.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
