[ https://issues.apache.org/jira/browse/STORM-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046703#comment-17046703 ]
Ethan Li commented on STORM-3589: --------------------------------- Thanks [~li530]. I merged this to master > Iterator in BaseResourceStrategy is potentially buggy > ----------------------------------------------------- > > Key: STORM-3589 > URL: https://issues.apache.org/jira/browse/STORM-3589 > Project: Apache Storm > Issue Type: Improvement > Affects Versions: 2.0.0, 2.1.0 > Reporter: Rui Li > Assignee: Rui Li > Priority: Minor > Labels: pull-request-available > Fix For: 2.2.0 > > Time Spent: 40m > Remaining Estimate: 0h > > [https://github.com/apache/storm/blame/master/storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java#L280] > We should probably only peek but not remove value from nodeIterator in > hasNext() function. > > [https://github.com/apache/storm/blame/master/storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java#L296-L300] > > And two consecutive next() call will cause problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)