jnioche opened a new pull request, #8444:
URL: https://github.com/apache/storm/pull/8444

    ## Summary                                                                  
                                                                                
                                                                              
   
     Second phase of porting Clojure tests to Java. Ports 21 test functions 
from 2                                                                          
                                                                                
     
     Clojure files to Java/JUnit 5.
                                                                                
                                                                                
                                                                                
 
     ## Changes                                                                 
                                                                                
                                                                               
   
     | Clojure source | Java target | Tests |                                   
                                                                                
                                                                                
 
     |---|---|---|
     | `storm-core/test/clj/org/apache/storm/scheduler_test.clj` | 
`storm-server/.../scheduler/SchedulerModelTest.java` | 4 |                      
                                                                                
              
     | 
`storm-core/test/clj/org/apache/storm/scheduler/multitenant_scheduler_test.clj` 
| `storm-server/.../scheduler/multitenant/MultitenantSchedulerTest.java` | 17 | 
                                                                        
   
     ### SchedulerModelTest (4 tests)                                           
                                                                                
                                                                                
 
      
     - `testSupervisorDetails` — SchedulerAssignmentImpl assign/unassign/query  
                                                                                
                                                                                
 
     - `testTopologies` — TopologyDetails.selectExecutorToComponent, 
Topologies.getById/getByName                                                    
                                                                                
          
     - `testCluster` — comprehensive Cluster class coverage (scheduling, ports, 
slots, assign, free)                                                            
                                                                                
 
     - `testSortSlots` — EvenScheduler.sortSlots round-robin ordering
                                                                                
                                                                                
                                                                                
 
     ### MultitenantSchedulerTest (17 tests)                                    
                                                                                
                                                                               
                                                                                
                                                                                
                                                                                
 
     - Node, FreePool, DefaultPool, IsolatedPool unit tests                     
                                                                                
                                                                                
 
     - End-to-end MultitenantScheduler tests with user pools
     - Edge cases: bad starting state, duplicate slot assignments, dead 
supervisors,                                                                    
                                                                                
         
       slots not reported by supervisor, nodes with different slot counts       
                                                                                
                                                                                
 
                                                                                
                                                                                
                                                                                
 
     ## Context                                                                 
                                                                                
                                                                                
 
                                                                                
                                                                                
                                                                                
 
     Phase 2 of 8 in the Clojure-to-Java test port. The 
`multitenant_scheduler_test`                                                    
                                                                                
                         
     had no Java equivalent — this is entirely new coverage for the multitenant 
scheduler.
     Clojure files are not deleted yet (cleanup happens in Phase 8).            
                                                                                
                                                                                
 
                                                                                
                                                                                
                                                                               
     ## Test plan                                                               
                                                                                
                                                                                
 
                                                                                
                                                                                
                                                                               
     - [x] `mvn test -pl storm-server 
-Dtest="SchedulerModelTest,MultitenantSchedulerTest"` — 21 tests, all pass      
                                                                                
                                           
      
     🤖 Generated with [Claude Code](https://claude.com/claude-code)             
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to