[
https://issues.apache.org/struts/browse/STR-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42073
]
Juan Duran commented on STR-3092:
---------------------------------
Don't you think that would imply loss of functionality? the messages tag
doesn't have the suffix and prefix properties.
Besides, messages tag is used for general purpose messages. Not only errors.
so if you want to say display an error in red, how would you know if it is an
error if it is invoked by the messages tag?
i perfectly could have something like this in the body of some jsp:
<p style="font-color:red"><html:errors /></p>
<p><html:messages '></p>
This way errors are displayed in red and general messages in the current font.
what do you think?
> ErrorsTag should filter arguments for html display
> --------------------------------------------------
>
> Key: STR-3092
> URL: https://issues.apache.org/struts/browse/STR-3092
> Project: Struts 1
> Issue Type: Improvement
> Components: Taglibs
> Affects Versions: 1.1.1
> Reporter: Juan Duran
> Assignee: Paul Benedict
> Priority: Minor
>
> Unlike bean:write, html:errors doesn't filter for html the arguments that
> may go along the message.
> In my opinion, those arguments should be filtered for html by default as this
> is the purpose of the ErrorsTag (to display in html).
> Sometimes we may want to include the user input in the error message after
> some validation. For example, say I want to validate that a nameserver is a
> valid registered nameserver. I would take the user input , run the
> validation service and would like my error message to be declared in the
> resources file as:
> error.invalid.dns={0} is not a registered nameserver
> if the user wants to screw my display, then he may enter something like
> "seehowthislooks<hr>" The html element doesn't get filtered out.
> I believe ErrorsTag should make use of TagUtils.filter(value) in the
> doStartTag method (which is used by org.apache.struts.taglib.bean.WriteTag).
> that would take care of this issue.
> workaround
> ----------------
> Of course, we could do the filter before creating the error (ActionMessage),
> but it would be nice to have this feature just as it happens with bean:write
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
