[
https://issues.apache.org/struts/browse/STR-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42784
]
Lars Beuster commented on STR-3117:
-----------------------------------
Cool issue? Paul, have a look at this:
https://issues.apache.org/struts/browse/STR-2239
;)
Since I have different applications that all use prefix mapping I think I'm a
good candidate (but I have no *.do-apps) to help you. I've already found (and
fixed for me) a few places that needs to :
- TagUtils.getActionMappingURL()
* see last comment yesterday
- ModuleUtils.getModuleName():
* if we have a prefix we need request.getPathInfo() instead of
request.getServletPath()
- PerformForward?
Another place that probably needs a fix is
- RequestUtils.actionIdURL() that adds the mapping but forgets the module (see
resolveModuleRelativePath()), so you get /prefix/action
Currently I don't use actionIds - I'm not quite sure if I known what actionIds
are ;).
I think at least the 3 mentioned Utils-classes should have a complete closer
look. And a few handy methods like
- isPrefixMapping()
- getPrefix()
- isStarDoMapping() - (there's room for name improvement)
would be nice.
I'm looking forward removing my Struts-hacks...
Regards
Lars
> PerformForward.methods: private -> protected
> --------------------------------------------
>
> Key: STR-3117
> URL: https://issues.apache.org/struts/browse/STR-3117
> Project: Struts 1
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.3.9
> Reporter: Lars Beuster
> Assignee: Paul Benedict
> Priority: Minor
> Fix For: 1.3.10
>
>
> The methods in chain.commands.servlet.PerformForward are private. To extend
> PerformInclude to make it easier to deal with prefix matching in the action
> servlet (e.g. "/main/*" instead of "*.do") it would be nice if I could
> override resolveModuleRelativePath().
> With the overridden method I could omit the action servlet prefix in the
> whole struts-config.xml:
> <action...>
> old: <forward name="success" path="/main/anotherAction" module="..."/>
> new: <forward name="success" path="/anotherAction" module="..."/>
> </action>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
