[
https://issues.apache.org/struts/browse/WW-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43929#action_43929
]
James Holmes commented on WW-2655:
----------------------------------
Agreed, but changing that now would potentially cause styling issues for folks
that rely on the way the tag works now.
Even so, I vote for changing this in the 2.1 release cycle and noting the
"backwards compatibiliy issue" in the release notes.
Thoughts from others?
It's a simple change to the *.ftl files.
> cssClass attribute in fielderror tag should be applied to the outside element
> -----------------------------------------------------------------------------
>
> Key: WW-2655
> URL: https://issues.apache.org/struts/browse/WW-2655
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Tags
> Affects Versions: 2.0.11.1
> Reporter: Hernan J. Gonzalez
> Priority: Minor
>
> The "cssClass" or "cssStyle" attributes on a <s:fielderror> tag is not
> applied to the outside <ul> element, but to the inside <span> element. I
> believe this goes against good css practice, and it limits with no good
> reason the css-customization.
> <ul class="myClass"><li><span>error msg</span></li></ul>
> is clearly better than the present
> <ul><li><span class="myClass">error msg</span></li></ul>
> because the former allows to style everything inside the whole element (for
> example, the <li> styles)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
