findbugs issues
---------------
Key: WW-3102
URL: https://issues.apache.org/struts/browse/WW-3102
Project: Struts 2
Issue Type: Bug
Components: Core Interceptors, Dispatch Filter, Other
Affects Versions: 2.1.6
Reporter: Dale Newfield
Priority: Minor
I don't know if running a static code analysis tool over the codebase is part
of the release process (getting ready for 2.1.7), so just for the hell of it I
just ran struts2 trunk through findbugs. It found 37 "bugs". Most of them are
not bugs (but rather not quite best practices), but many could be easily
addressed. The attached patches address those that didn't require too much
domain knowledge :-). I *believe* that the patches don't have any semantic
effect on the codebase, and they reduce the number of issues raised by findbugs
from 37 to 11.
One issue findbugs points out is that the BackgroundProcess constructor starts
it's thread before returning, which means that any subclass won't get to finish
it's constructor before the thread is started. This is relevant to the
solution offered at
http://cwiki.apache.org/WW/hibernateandspringenabledexecuteandwaitinterceptor.html
and I'm not sure if it's really an issue or how to fix it (but I'm interested
since I use something like that in my current project :-).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
