[ https://issues.apache.org/struts/browse/STR-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46517#action_46517 ]
Wes Wannemacher commented on STR-3191: -------------------------------------- Paul, the only thing I would change is that these don't appear to be if/else statements, so I would just reuse the same instance of TagUtils, rather than calling getInstance() over and over again. Of course, I didn't look at what TagUtils contains, so this may not be appropriate. -Wes > Sufficently filter HTML tag attribute names and values > ------------------------------------------------------ > > Key: STR-3191 > URL: https://issues.apache.org/struts/browse/STR-3191 > Project: Struts 1 > Issue Type: Bug > Components: Tag Libraries > Affects Versions: 1.2.9, 1.3.10 > Reporter: Paul Benedict > Assignee: Paul Benedict > Priority: Blocker > Fix For: 1.3.11, 1.4.0 > > Attachments: STR-3191-patch.txt > > > Allows remote attackers to inject arbitrary web script or HTML via > unspecified vectors related to insufficient quoting of parameters. > * https://bugzilla.redhat.com/show_bug.cgi?id=CVE-2008-2025 > * http://support.novell.com/security/cve/CVE-2008-2025.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.