[ https://issues.apache.org/struts/browse/STR-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47104#action_47104 ]
Andrew Kelly commented on STR-2893: ----------------------------------- Any word on when 1.3.11 will be released? > FormTag doesn't render the focus javascript compliant with xhtml > ---------------------------------------------------------------- > > Key: STR-2893 > URL: https://issues.apache.org/struts/browse/STR-2893 > Project: Struts 1 > Issue Type: Bug > Components: Tag Libraries > Affects Versions: 1.2 Family > Environment: Windows XP SP2, IBM Think Centre > Reporter: Tedy Marcos Colombini > Assignee: Paul Benedict > Priority: Trivial > Fix For: 1.3.11, 1.4.0 > > > Taking a look at the FormTag code (precisely, the renderFocusJavascript() > method), I found this: > // xhtml script content shouldn't use the browser hiding trick > if (!this.isXhtml()) { > results.append(" <!--"); > results.append(lineEnd); > } > I guess the if statement should be the opposite, since we need javascript > code inside <!-- ... --> for xhtml compliance, don't we? > Also, the following snippet doesn't need the !this.isXhtml() check... > if (!this.isXhtml() && this.scriptLanguage) { > results.append(" language=\"JavaScript\""); > } > Regards, Tedy. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.