[ https://issues.apache.org/jira/browse/WW-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995920#comment-12995920 ]
Dave Newton commented on WW-3578: --------------------------------- Do you not have an "edit" link? > replace function is called multiple times, which can be done in one run > ----------------------------------------------------------------------- > > Key: WW-3578 > URL: https://issues.apache.org/jira/browse/WW-3578 > Project: Struts 2 > Issue Type: Bug > Components: Plugin - JasperReports > Affects Versions: 2.2.1.1 > Reporter: Xiaoming Shi > > In the function "makeXmlJavaIdentifier" > (./struts-2.2.1/src/plugins/embeddedjsp/src/main/java/org/apache/struts2/jasper/compiler/JspUtil.java > line: 1059) > The replace function is called 3 times, which can be done in one run with a > for loop. > StringBuilder sb = new StringBuilder(name.length()); > for(int i = 0; i < name.length(); i++) > { > char c = name.charAt(i); > if (c == '-') > sb.append("$1"); > else if (c == '.') > sb.append("$2"); > else if (c == ':') > sb.append("$3"); > else > sb.append(c); > } > return sb.toString(); > The second method can be much faster . -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira