[
https://issues.apache.org/jira/browse/WW-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
István Székely updated WW-3461:
-------------------------------
Attachment: thread_dump-20110615-1324.tar.bz2
The attached thread dump shows what I suspected. The blocked threads' stack
trace contains the AnnotationActionValidatorManager.buildValidatorConfigs()
method.
Please note our production environment does not use the most recent JDK version:
- Ubuntu 10.04.2 LTS 2.6.38-8-server SMP x86_64
- Sun JDK 6u13 from tarball
- Tomcat 6.0.29
- Struts 2.2.3
> Don't hold locks as long when creating validators in
> AnnotationActionValidatorManager
> -------------------------------------------------------------------------------------
>
> Key: WW-3461
> URL: https://issues.apache.org/jira/browse/WW-3461
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.1.6
> Reporter: Leigh Anderson
> Assignee: Lukasz Lenart
> Fix For: 2.2.3
>
> Attachments: WW-3461.patch, WW-3461.patch,
> thread_dump-20110615-1324.tar.bz2, validatormanager.patch
>
>
> Under load, the lock held in AnnotationActionValidatorManager.getValidators
> on validatorCache becomes contended. This lock is currently held while all
> the validators are created. The attached patch reduces the scope of the lock
> to just doing the cache lookup + taking a defensive copy of the list of
> validators for that key. This improved throughput and latency in our tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
