[ 
https://issues.apache.org/jira/browse/WW-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058598#comment-13058598
 ] 

Johno Crawford edited comment on WW-3655 at 7/1/11 3:29 PM:
------------------------------------------------------------

Perhaps I am missing the point, but isn't the purpose of the feature in 
question suppose to generate a prefix for the result location based on the 
request uri path? The following example should trigger the use case.

{code}
<action name="index" class="com.acme.IndexAction">
    <result name="success" type="freemarker">com/acme/nested.ftl</result>
</action>
{code}

      was (Author: johno):
    Perhaps I am missing the point, but isn't the purpose of the feature in 
question suppose to generate a prefix for the result location based on the 
request uri path?

{code}
<action name="index" class="com.acme.IndexAction">
    <result name="success" type="freemarker">com/acme/nested.ftl</result>
</action>
{code}
  
> Freemarker result loads request uri as template
> -----------------------------------------------
>
>                 Key: WW-3655
>                 URL: https://issues.apache.org/jira/browse/WW-3655
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.2.3
>            Reporter: Johno Crawford
>            Assignee: Maurizio Cucchiara
>
> If the template location is either null or an empty string "" 
> FreemarkerResult will take the request uri 
> org.apache.struts2.views.freemarker.FreemarkerResult#doExecute and load it as 
> a template.
> Example url, http://localhost:8080/com/acme/actions/Action.class/ would load 
> /com/acme/actions/Action.class/ as a template and dump the bytecode in the 
> response.
> The "feature" / culprit below seems a little exotic, however someone may be 
> relying on it.. (same actions handling stuff in different directories?)
> {code}
> if (!locationArg.startsWith("/")) {
>             String base = ResourceUtil.getResourceBase(req);
>             locationArg = base + "/" + locationArg;
> }
> {code}
> To mitigate the problem and maintain previous functionality we could throw an 
> exception if the template location is empty, I have created a pull request 
> with my proposed fix https://github.com/apache/struts2/pull/1

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to