[ 
https://issues.apache.org/jira/browse/WW-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416264#comment-13416264
 ] 

Maurizio Cucchiara commented on WW-3852:
----------------------------------------

Ciao Lorenzo,
no objection from my side to make {{getTextMessage}} protected, I would just 
like to investigate if there is a better way to make interceptors aware.
                
> CLONE - FileUploadInterceptor and TokenInterceptor should use the configured 
> custom TextProvider
> ------------------------------------------------------------------------------------------------
>
>                 Key: WW-3852
>                 URL: https://issues.apache.org/jira/browse/WW-3852
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Interceptors
>    Affects Versions: 2.3.4
>            Reporter: Lorenzo Bernacchioni
>            Assignee: Maurizio Cucchiara
>              Labels: i18n, interceptors
>             Fix For: 2.3.4
>
>
> Struts2 supports the usage of a custom text provider by setting some 
> environment constants in struts.xml:
> example:
> <bean class="test.CustomTextProvider" name="myTextProvider" 
> type="com.opensymphony.xwork2.TextProvider" /> 
> <constant name="struts.xworkTextProvider" value="myTextProvider" />
> The struts2 core FileUploadInterceptor and the TokenInterceptor don't use 
> this new custom TextProvider hence they use  XWork's LocalizedTextUtil class 
> to lookup translations. Why the translations don't get resolved via an 
> injected TextProvider?
> At least method:
> private String getTextMessage(Object action, String messageKey, Object[] 
> args, Locale locale) {
> should have a "protected" signature to allow override.
> More comments in the WW-3552 Clone.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to